You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@danieliser We probably need to define a strategy to move forward on this. If we get the asset cache disabling lower, it would help but we will always have some that disable the cache for whatever reason.
Right now, all of our integration JS files combined only equals 10 KB. The generated (non-minified) site.js file is around 140 KB. So it would only increase that file by 7% to add all form integration JS into the core site.js file. After minification, that file would still be less than 60 KB which is still really good compared to all the other files WP and plugins are loading on most sites.
@fpcorso Eventually they were to be loaded into the main js bundle, the reason it wasn't is because the integrations are all written in ES6 and use Webpack bundler, the old code still is ES5 and bundled manually using Gulp routines.
To merge them effectively during build we need to adjust the gulp routine to merge those files into the main bundle. Might require making the normal JS build task call the webpack tasks first.
Can either just bundle them all by default into core JS for now or conditionally enqueue them if they are active and asset cache is inactive.
The text was updated successfully, but these errors were encountered: