Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch H2 for Nav with any of our page tabs #818

Closed
fpcorso opened this issue Jun 4, 2020 · 2 comments
Closed

Switch H2 for Nav with any of our page tabs #818

fpcorso opened this issue Jun 4, 2020 · 2 comments

Comments

@fpcorso
Copy link
Contributor

fpcorso commented Jun 4, 2020

Since we have H1 as the page title and then have H2's usually right after the tabs, I don't think H2 makes sense here in terms of page structure.

I will research more on structure/accessibility and update this issue.

@fpcorso
Copy link
Contributor Author

fpcorso commented Oct 6, 2020

Yes, these should be nav and not h2.

The newer WP pages have the tabs as nav as well:
image

On our screen, there are two H2 elements in appropriate places already (they are hidden screen-recorder headings):
image

So, for structure and accessibility, these should be nav.

@fpcorso fpcorso changed the title Consider switching H2 for Nav with any of our page tabs Switch H2 for Nav with any of our page tabs Oct 6, 2020
fpcorso added a commit that referenced this issue Oct 6, 2020
@fpcorso fpcorso closed this as completed Oct 6, 2020
@danieliser
Copy link
Member

@fpcorso To be fair WP changed those in the recent past. The original tabs were taken from existing interfaces within WP admin at the time they were written so they would use core styles :).

As long as core has new styles for

then perfect.

@fpcorso fpcorso mentioned this issue Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants