Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate deployment of non functional assets to wp.org #827

Closed
fpcorso opened this issue Jun 10, 2020 · 5 comments
Closed

Automate deployment of non functional assets to wp.org #827

fpcorso opened this issue Jun 10, 2020 · 5 comments
Milestone

Comments

@fpcorso
Copy link
Contributor

fpcorso commented Jun 10, 2020

Utilizing GitHub actions or similar scripts, we can commit any readme and WordPress.org-specific assets changes to the WordPress.org plugin repository.

10up has an action for this already: https://github.com/10up/action-wordpress-plugin-asset-update

Originally apart of #711

@fpcorso fpcorso added this to the v1.12 milestone Jun 10, 2020
@fpcorso fpcorso mentioned this issue Jun 10, 2020
3 tasks
@fpcorso
Copy link
Contributor Author

fpcorso commented Aug 6, 2020

@danieliser Just realized that we don't keep wp.org assets in the repo. Makes it difficult to hunt down the assets to switch them out and makes this automated deployment not possible.

Should we add the wp.org assets to the repo and, if so, where?

@fpcorso fpcorso modified the milestones: v1.12, v1.13 Aug 6, 2020
@danieliser
Copy link
Member

danieliser commented Aug 6, 2020

Yea that was part of #791 too, that is the only way to manage them via that action.

@fpcorso
Copy link
Contributor Author

fpcorso commented Aug 6, 2020

@danieliser Looks like if we continue as planned to the 10up action above, they have a slug for us to point to which directory we use for the assets:
image

I like their default .wordpress-org folder which would sit alongside our .github folder as another non-development directory. Are you good with keeping that directory name?

@danieliser
Copy link
Member

@fpcorso Yea a . folder keeps it well out of the normal structures.

fpcorso added a commit that referenced this issue Aug 18, 2020
…ess.org

We are planning on eventually auto-deploying these so this is a good first step towards that.

Issue #827
fpcorso added a commit that referenced this issue Aug 18, 2020
@fpcorso
Copy link
Contributor Author

fpcorso commented Oct 6, 2020

@danieliser Tested this on one of my tiny plugins. The 10up action will update the readme in trunk and in the tag folder that matches the stable tag. It did not touch any other files so it should be good.

So, we just need to add SVN credentials (see the thread in Slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants