Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scheduled Actions page to Popup Maker menu #859

Closed
fpcorso opened this issue Jul 22, 2020 · 4 comments
Closed

Add Scheduled Actions page to Popup Maker menu #859

fpcorso opened this issue Jul 22, 2020 · 4 comments

Comments

@fpcorso
Copy link
Contributor

fpcorso commented Jul 22, 2020

The ActionScheduler package we now use within Popup Maker adds a new "Scheduled Actions" page. To make it easier to refer people to it, we should consider mirroring what WooCommerce does and add that page within our menu.

@fpcorso fpcorso added this to the v1.12 milestone Jul 22, 2020
@fpcorso
Copy link
Contributor Author

fpcorso commented Aug 3, 2020

@danieliser WooCommerce puts theirs as a tab within the "Status" page. It might make sense for us to put ours within the "Tools" page. Is there a different location that you feel would be better suited for this page?

@danieliser
Copy link
Member

@fpcorso That works for now. I think if we redo our menus like EDD v3 does it might get relabeled, but those tools will probably all stay together.

@fpcorso
Copy link
Contributor Author

fpcorso commented Aug 10, 2020

@danieliser Not too bad. Most of their code is abstract enough that it was as simple as creating an admin view instance and calling the render method:
image

fpcorso added a commit that referenced this issue Aug 10, 2020
@fpcorso fpcorso closed this as completed Aug 10, 2020
@danieliser
Copy link
Member

Looks good.

@fpcorso fpcorso mentioned this issue Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants