You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upon debugging, I discovered that some fields are left where the $value is false. So, during the check for if the $field is false, it passes the not empty check leading the code to go to the $field['private'] check which throws this error since $field is false.
The text was updated successfully, but these errors were encountered:
@danieliser For the empty check, I think the very point of it is this use case. If a field no longer exists and there is a value, pass it through.
So, in that case, I think your solution of changing the empty to an isset is probably the right choice. I'll review the code and debug a bit more to make sure that change doesn't break anything. If not, I'll commit that.
Describe the bug
After de-activating Videos, Scheduling, or Forced Interaction, a warning begins to appear when viewing pages that popups are loaded on.
Site information
Popup Maker version: 1.12
WordPress version: 5.5
PHP version: 7.4
Errors
Error originating from this line: https://github.com/PopupMaker/Popup-Maker/blob/master/classes/Model/Popup.php#L229
Additional context
Upon debugging, I discovered that some fields are left where the
![field-debugging](https://user-images.githubusercontent.com/9730040/90803962-8b437c80-e2e7-11ea-9482-432aca59f24f.png)
$value
isfalse
. So, during the check for if the$field
is false, it passes the not empty check leading the code to go to the$field['private']
check which throws this error since$field
is false.The text was updated successfully, but these errors were encountered: