Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup defaults() method only returns default values for checkbox fields #927

Closed
fpcorso opened this issue Dec 22, 2020 · 1 comment
Closed

Popup defaults() method only returns default values for checkbox fields #927

fpcorso opened this issue Dec 22, 2020 · 1 comment
Labels
type-bug
Milestone
v1.15

Comments

@fpcorso
Copy link
Contributor

fpcorso commented Dec 22, 2020

Describe the bug

Right now, our defaults() method for popups is only returning default values for checkbox fields. This is due to an if condition here: https://github.com/PopupMaker/Popup-Maker/blob/master/classes/Admin/Popups.php#L1025
@fpcorso fpcorso added this to the v1.15 milestone Dec 22, 2020
fpcorso added a commit that referenced this issue Dec 22, 2020
@fpcorso
Fix defaults() method to return all default values
185e4c5 
Fix issue #927
@fpcorso
Copy link
Contributor Author

fpcorso commented Dec 22, 2020

Fixed in a recent commit in develop

@fpcorso fpcorso closed this as completed Dec 22, 2020
@fpcorso fpcorso mentioned this issue Jan 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug
Projects
None yet
Milestone
v1.15
Development

No branches or pull requests
1 participant
@fpcorso