Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility focus first element doesn't work if no focusable element #943

Closed
danieliser opened this issue Feb 21, 2021 · 0 comments
Closed

Accessibility focus first element doesn't work if no focusable element #943

danieliser opened this issue Feb 21, 2021 · 0 comments
Milestone
v1.16

Comments

@danieliser
Copy link
Member

The issue seems 2 fold.

  1. The first focus element search excludes the close button.
  2. The event seems to occur beforeOpen vs afterOpen
@danieliser danieliser added this to the v1.16 milestone Feb 21, 2021
danieliser added a commit that referenced this issue Feb 21, 2021
@danieliser
Fixe focus first element issues
c2be371 
1. Moved to the afterOpen event.
2. Allowed focusing close button.

Resolves #943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.16
Development

No branches or pull requests
1 participant
@danieliser