Allow for mipmapping in texture atlas. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possseidon
force-pushed
the
dev/mipmapping
branch
from
b29cdc9
to
a6e4584
Compare
Possseidon
commented
Apr 15, 2022
| size[v_indices]...); | ||
| if (!mipmap_levels) { | ||
| if constexpr (v_target == TextureTarget::Texture1DArray) | ||
| mipmap_levels = mipmapCount(size.x().maxValue()); |
There was a problem hiding this comment.
size.x() is just a GLsizei and does not have .maxValue().
Can I just use only .maxValue() everywhere and get rid of these if constexpr checks?
Possseidon
force-pushed
the
dev/mipmapping
branch
3 times, most recently
from
01a570d
to
9a03579
Compare
Also removed automatic mipmap generation in "generate".
Main appeal is, that it also works for unsigned types.
It no longer has constructor overloads on BorderedImageData::Image.
- Use std::size_t everywhere. - Get rid of a load of static_casts. - Those are now in the OpenGL specializations. - Fix ensureTextureSize for zero sized textures. - Added support for MipmapLevels in tests.
for more information, see https://pre-commit.ci
Possseidon
force-pushed
the
dev/mipmapping
branch
from
9a03579
to
0fcf4d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.