Add tests for dang-lua Convert and State. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possseidon
force-pushed
the
dev/lua-tests
branch
2 times, most recently
from
e3b0654
to
8d7373c
Compare
Possseidon
force-pushed
the
dev/lua-tests
branch
from
67fdd11
to
cc1138d
Compare
Possseidon
force-pushed
the
dev/lua-tests
branch
from
a76a434
to
c271f92
Compare
Possseidon
force-pushed
the
dev/lua-tests
branch
2 times, most recently
from
a41eab3
to
2bc4336
Compare
Convert::at doesn't work properly, as you can't have an optional of nullopt_t.
- Split Convert enum and class using SFINAE. - TODO: Fix comments! - Added enum_name instead of using ClassInfo. - Use SFINAE instead of subclassing for const and ref.
Now also testing const/ref types when appropriate.
Accidentally added null functions into Lua... oups! Also added another safety assert for normal methods.
- Now checking the error string returned by shouldThrow. - This will break tests when Lua changes some messages unfortunately. - Not checking errors at all is pretty bad though, as a lot of other things can go wrong. - Added a test for pushing/checking userdata with ClassInfo. - Added another huge test for various ClassInfo specializations. - All combinations of table, metatable and properties.
- Convert now split between can_check and can_push. - All ClassInfo Lua types can now be closed (freed). - A whole bunch of other stuff...
And a lot of other stuff... Why can I not commit more frequently.
Also removed a redundant "detail::".
- Also added a note as to why in Convert.h. - It can cause issues with new partial specializations after an instantiation.
Also removed some existing inlines that are already implied by constexpr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.