fix cloud run worker v2 vpc access

PrefectHQ · Apr 21, 2024 · 30a121f · 30a121f
1 parent 250df53
commit 30a121f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/prefect_gcp/workers/cloud_run_v2.py b/prefect_gcp/workers/cloud_run_v2.py
@@ -247,7 +247,7 @@ def _remove_vpc_access_if_unset(self):
         # if connector is the only key and it's not set, we'll remove it.
         # otherwise we'll pass whatever the user has provided.
         if len(vpc_access) == 1 and vpc_access.get("connector") is None:
-            self.job_body["template"]["template"]["vpcAccess"] = None
+            self.job_body["template"]["template"].pop("vpcAccess")
 
     # noinspection PyMethodParameters
     @validator("job_body")

diff --git a/tests/test_cloud_run_worker_v2.py b/tests/test_cloud_run_worker_v2.py
@@ -132,8 +132,8 @@ def test_remove_vpc_access_if_unset(self, cloud_run_worker_v2_job_config):
         cloud_run_worker_v2_job_config._remove_vpc_access_if_unset()
 
         assert (
-            cloud_run_worker_v2_job_config.job_body["template"]["template"]["vpcAccess"]
-            is None
+            "vpcAccess"
+            not in cloud_run_worker_v2_job_config.job_body["template"]["template"]
         )
 
     def test_vpc_access_left_alone_if_connector_set(