This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add BigQuery row to dictionary conversion in list #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Thanks for the contribution @davidschrooten! I have a suggestion for a more extensible way to introduce result transformation. Let me know what you think. Once we've agreed on an approach, it'd also be ideal to have some tests covering the new functionality.
desertaxle
reviewed
May 2, 2023
davidschrooten
force-pushed
the
bigquery-dictionary-list
branch
from
dc3c274
to
462dec0
Compare
desertaxle
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using prefect-gcp you are forced to use pandas dataframe when using a task runner such as Ray or Dask. These task runners pickle the objects, but with large rows it can result in a maximum recursion depth exceeded exception, when you're using lists with Bigquery Row objects. This PR implements a optional row_as_dict argument. It also contains one minor typing hint fix. As the bigquery_query function also supports the return of a pandas dataframe.