Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix: Bug that put_directory method in cloud_storage.py(GcsBucket) do not upload files that in directory #188

Closed
wants to merge 9 commits into from

Conversation

milk531
Copy link

@milk531 milk531 commented Jun 8, 2023

Closes

Example

Screenshots

pre-commit test
pass

docs not change

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@milk531 milk531 requested a review from a team June 8, 2023 04:21
@desertaxle
Copy link
Member

Thanks for the contribution @milk531! Could you please add a test verifying that this new functionality works as expected?

@milk531 milk531 requested a review from a team as a code owner July 9, 2023 11:06
@milk531 milk531 closed this Jul 9, 2023
@milk531 milk531 force-pushed the main branch 2 times, most recently from 1f7b47c to 9ca9af3 Compare July 9, 2023 11:11
@milk531 milk531 reopened this Jul 9, 2023
@milk531
Copy link
Author

milk531 commented Jul 13, 2023

Thanks for the contribution @milk531! Could you please add a test verifying that this new functionality works as expected?

the new test has been added to the code

@desertaxle
Copy link
Member

Hey @milk531, looks like there are some failing tests on this PR. Looks like you need to update existing tests to account for the two new test files that you added.

@desertaxle
Copy link
Member

Thank you for your willingness to contribute to prefect-gcp! The code for this library has been moved to https://github.com/PrefectHQ/prefect/tree/main/src/integrations/prefect-gcp. Please reopen this PR there if this functionality is still needed!

@desertaxle desertaxle closed this Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants