This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Persist Labels to Vertex AI Custom Job #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the contribution @jhamet93! it looks like the pre-commits are failing, could you go ahead and run those locally and push things back up? |
jhamet93
force-pushed
the
Persist_Labels_To_GCP_Resource
branch
from
48e2099
to
80500cb
Compare
jhamet93
force-pushed
the
Persist_Labels_To_GCP_Resource
branch
from
80500cb
to
e610be3
Compare
Done! |
desertaxle
suggested changes
Aug 7, 2023
Great thanks! Amended the method name. |
jeremy-thomas-roc
pushed a commit
to jeremy-thomas-roc/prefect-gcp
that referenced
this pull request
Aug 31, 2023
* Persist Labels to Vertex AI Custom Job * ensure compatible with GCP requirements * small bug not fetching key-value pairs * Add test, changelog, and format * pre commit hook changes * Feedback for method name --------- Co-authored-by: Alexander Streed <[email protected]>
desertaxle
added a commit
that referenced
this pull request
Sep 19, 2023
* add accelerator count * update changelog * added test * fix jobs not canceling in vertex * add accelerator count * update changelog * added test * fix jobs not canceling in vertex * revert bad changes * update changelog * update changelog * added test * revert bad changes * update changelog * update changelog * Bump JamesIves/github-pages-deploy-action from 4.4.2 to 4.4.3 (#196) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.4.2 to 4.4.3. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.4.2...v4.4.3) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexander Streed <[email protected]> * Persist Labels to Vertex AI Custom Job (#198) * Persist Labels to Vertex AI Custom Job * ensure compatible with GCP requirements * small bug not fetching key-value pairs * Add test, changelog, and format * pre commit hook changes * Feedback for method name --------- Co-authored-by: Alexander Streed <[email protected]> * revert * add optional vertex job name * update changelog * revert bad merge * change job name to reference flow run name * changelog * handle none values * handle none values * code review changes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexander Streed <[email protected]> Co-authored-by: Josh Hamet <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Prefect Agent fetches the
Infrastructurefrom aDeploymentto execute aFlowRunfor a particularFlow, a set of labels is computed and set in the associatedInfrastructurefor a particular deployment.https://github.com/PrefectHQ/prefect/blob/e530ca3285764accaef9360ba17e84610cb7e0cf/src/prefect/infrastructure/base.py#L88-L119
It would be helpful if these labels can be persisted to the underlying Vertex AI Custom Job resource. This would enable effective querying for particular jobs that match a given condition (e.g. all the CustomJobs associated with a particular
FlowRun). Otherwise especially in environments where manyCustomJobsare run, it's cumbersome to make the association and attribution.Closes #200
Checklist
pre-commitchecks.pre-commit install && pre-commit run --alllocally for formatting and linting.mkdocs serveview documentation locally.