feat: Vertex AI `CustomJob` worker #211

parkedwards · 2023-09-14T23:49:56Z

This PR adds a Vertex AI Custom Worker type, which is a port over from the existing Infrastructure VertexAICustomTrainingJob block

Closes PrefectHQ/prefect#10478

Example

Screenshots

Docs

Checklist

References any related issue by including "Closes #" or "Closes ".
- If no issue exists and your change is not a small fix, please create an issue first.
Includes tests or only affects documentation.
Passes pre-commit checks.
- Run pre-commit install && pre-commit run --all locally for formatting and linting.
Includes screenshots of documentation updates.
- Run mkdocs serve view documentation locally.
Summarizes PR's changes in CHANGELOG.md

prefect_gcp/vertex_worker.py

prefect_gcp/__init__.py

parkedwards · 2023-09-15T19:08:13Z

tests/test_vertext_worker.py

@@ -0,0 +1,123 @@
+import uuid


these are passing, but im getting weird SAWArnings

parkedwards · 2023-09-15T19:15:02Z

i need to add the documentation docstring + changelog

chrisguidry

I did a good bit of testing with this this morning and it was working great! Nice work!!

desertaxle

Thanks for creating this so quickly! I have a few comments on structure which may have an impact on implementation. Once we've sorted them out then I can make another detailed pass. Let me know if you have any questions!

prefect_gcp/__init__.py

mkdocs.yml

prefect_gcp/vertex_worker.py

…atting

prefect_gcp/__init__.py

prefect_gcp/workers/vertex.py

parkedwards · 2023-09-19T19:16:34Z

prefect_gcp/workers/vertex.py

+    """Returns a base job body to use for job spec validation.
+    Note that the values are stubbed and are not used for the actual job."""
+    return {
+        "maximum_run_time_hours": "1",


im just validating against the presence of keys, so not going to validate against the provided values (since they generally come from a set of acceptable values)

prefect_gcp/workers/vertex.py

desertaxle

Final round of comments after a more thorough review. Once these are taken care of, this should be good to go.

I noticed that there's no kill_infrastructure command on this worker needed to support flow run cancellation. If you'd rather leave that out of this PR, let me know, and I can create an issue to track adding it later.

prefect_gcp/workers/vertex.py

parkedwards · 2023-09-21T17:55:48Z

I noticed that there's no kill_infrastructure command on this worker needed to support flow run cancellation. If you'd rather leave that out of this PR, let me know, and I can create an issue to track adding it later.

@desertaxle doh - let me add that, but in a follow up PR bc this one is getting beefy with comments. i'll create an issue for it so i dont forget

#212

parkedwards · 2023-09-21T17:58:57Z

prefect_gcp/workers/cloud_run.py

-    _documentation_url = "https://prefecthq.github.io/prefect-gcp/worker/"
-    _logo_url = "https://images.ctfassets.net/gm98wzqotmnx/4SpnOBvMYkHp6z939MDKP6/549a91bc1ce9afd4fb12c68db7b68106/social-icon-google-cloud-1200-630.png?h=250"  # noqa
+    _documentation_url = "https://prefecthq.github.io/prefect-gcp/cloud_run_worker/"
+    _logo_url = "https://cdn.sanity.io/images/3ugk85nk/production/10424e311932e31c477ac2b9ef3d53cefbaad708-250x250.png"  # noqa


this pr splits up the worker docs, so this page url needed updating as well

i also swapped the logo urls for all the links, lemme know if i went too far

That's awesome! Thanks!

desertaxle

LGTM! 🚀

parkedwards commented Sep 15, 2023

View reviewed changes

prefect_gcp/vertex_worker.py Outdated Show resolved Hide resolved

parkedwards commented Sep 15, 2023

View reviewed changes

prefect_gcp/__init__.py Outdated Show resolved Hide resolved

parkedwards commented Sep 15, 2023

View reviewed changes

parkedwards marked this pull request as ready for review September 15, 2023 19:14

parkedwards requested a review from a team as a code owner September 15, 2023 19:14

parkedwards changed the title ~~feat: initial Vertex AI CustomJob worker~~ feat: Vertex AI CustomJob worker Sep 15, 2023

chrisguidry approved these changes Sep 15, 2023

View reviewed changes

desertaxle reviewed Sep 18, 2023

View reviewed changes

prefect_gcp/__init__.py Outdated Show resolved Hide resolved

mkdocs.yml Outdated Show resolved Hide resolved

prefect_gcp/vertex_worker.py Outdated Show resolved Hide resolved

parkedwards and others added 8 commits September 18, 2023 14:29

initial worker commit

70a11cc

Rename the module so we can import/register it; fix command-line form…

4957446

…atting

make image required, more comments

ced14c2

tests

0ad73f5

docs

e46250f

remove unneeded defaults

0f67d5b

oops

d7da08f

fix test, and rename file

effe02e

parkedwards force-pushed the feat/vertex-worker branch from f82996e to effe02e Compare September 18, 2023 21:30

parkedwards added 3 commits September 18, 2023 16:02

combine to new workers module, fix docs

d358d67

fix test and rename file

2b5be98

add configurable job spec, schema validation

c19253c

parkedwards commented Sep 19, 2023

View reviewed changes

prefect_gcp/__init__.py Show resolved Hide resolved

parkedwards commented Sep 19, 2023

View reviewed changes

prefect_gcp/workers/vertex.py Outdated Show resolved Hide resolved

parkedwards commented Sep 19, 2023

View reviewed changes

prefect_gcp/workers/vertex.py Outdated Show resolved Hide resolved

creds

54fa575

parkedwards commented Sep 19, 2023

View reviewed changes

prefect_gcp/workers/vertex.py Outdated Show resolved Hide resolved

parkedwards added 2 commits September 19, 2023 12:21

pass in creds as config variable

583210f

Merge branch 'main' into feat/vertex-worker

bec7a4a

desertaxle suggested changes Sep 20, 2023

View reviewed changes

parkedwards added 4 commits September 21, 2023 10:28

remove unneeded checks

484e7ed

fix doc links

b275ca4

set defaults on the variable config

6b5e31a

be better at python

bbf5211

parkedwards requested a review from desertaxle September 21, 2023 17:56

parkedwards added 2 commits September 21, 2023 10:57

logogogogo

e80e7b7

all logos

fdc8210

parkedwards commented Sep 21, 2023

View reviewed changes

dont get cute

a7237b1

desertaxle approved these changes Sep 21, 2023

View reviewed changes

parkedwards merged commit 6327600 into main Sep 21, 2023
10 checks passed

parkedwards deleted the feat/vertex-worker branch September 21, 2023 20:58

parkedwards mentioned this pull request Sep 21, 2023

feat: add kill_infrastructure implementation for vertex ai worker #213

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Vertex AI `CustomJob` worker #211

feat: Vertex AI `CustomJob` worker #211

parkedwards commented Sep 14, 2023 •

edited

Loading

parkedwards Sep 15, 2023

parkedwards commented Sep 15, 2023

chrisguidry left a comment

desertaxle left a comment

parkedwards Sep 19, 2023

desertaxle left a comment

parkedwards commented Sep 21, 2023 •

edited

Loading

parkedwards Sep 21, 2023

desertaxle Sep 21, 2023

desertaxle left a comment

feat: Vertex AI CustomJob worker #211

feat: Vertex AI CustomJob worker #211

Conversation

parkedwards commented Sep 14, 2023 • edited Loading

Example

Screenshots

Checklist

parkedwards Sep 15, 2023

Choose a reason for hiding this comment

parkedwards commented Sep 15, 2023

chrisguidry left a comment

Choose a reason for hiding this comment

desertaxle left a comment

Choose a reason for hiding this comment

parkedwards Sep 19, 2023

Choose a reason for hiding this comment

desertaxle left a comment

Choose a reason for hiding this comment

parkedwards commented Sep 21, 2023 • edited Loading

parkedwards Sep 21, 2023

Choose a reason for hiding this comment

desertaxle Sep 21, 2023

Choose a reason for hiding this comment

desertaxle left a comment

Choose a reason for hiding this comment

feat: Vertex AI `CustomJob` worker #211

feat: Vertex AI `CustomJob` worker #211

parkedwards commented Sep 14, 2023 •

edited

Loading

parkedwards commented Sep 21, 2023 •

edited

Loading