-
Notifications
You must be signed in to change notification settings - Fork 26
Update placement of vpc-connector details for Cloud Run Work Pool #223
Conversation
A couple of questions.
|
hi @JohnLemmonMedely - thank you for the PR I agree - I think you're good on this
Hmm I'm not sure off the top of my head - @jakekaplan do we use this implementation for the push pool? |
This implementation is not directly used for the push pool, but I am happy to port this change over |
44cb764
to
31cbeee
Compare
@zzstoatzz What do we need to merge this in? |
@zzstoatzz or @jakekaplan what needs to be done to merge this PR in? |
@JohnLemmonMedely apologies for the delayed reply! I missed your original message. I've updated and released the push pool implementation to match your implementation here. Will make sure this gets merged in tomorrow for workers/hybrid pools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@JohnLemmonMedely if you could merge in main and fix CHANGELOG.md
that'd be great
31cbeee
to
494f89b
Compare
@jakekaplan Thank you! I just dropped the CHANGELOG commit, it looks like it's been removed going forward? |
Google changed where the vpc-connector details need to be included in the API request for Cloud Run jobs. Looks like this has been fixed in the Cloud Run Job in this repo but not the work pool, so this change updates the work pool as well.
Closes #218
Example
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.