Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update placement of vpc-connector details for Cloud Run Work Pool #223

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

JohnLemmonMedely
Copy link
Contributor

@JohnLemmonMedely JohnLemmonMedely commented Nov 6, 2023

Google changed where the vpc-connector details need to be included in the API request for Cloud Run jobs. Looks like this has been fixed in the Cloud Run Job in this repo but not the work pool, so this change updates the work pool as well.

Closes #218

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@JohnLemmonMedely JohnLemmonMedely requested a review from a team as a code owner November 6, 2023 20:28
@JohnLemmonMedely
Copy link
Contributor Author

A couple of questions.

  1. Do I need a unit test here? I think it's redundant because it would just test the placement of the vpc info within the JSON but I can add it if needed.
  2. I'm really trying to fix the cloud-run:push work pool in Prefect Cloud. Will this change roll up into that work pool?

@zzstoatzz
Copy link
Contributor

zzstoatzz commented Nov 29, 2023

hi @JohnLemmonMedely - thank you for the PR

I agree - I think you're good on this

Do I need a unit test here?

Will this change roll up into that work pool?

Hmm I'm not sure off the top of my head - @jakekaplan do we use this implementation for the push pool?

@jakekaplan
Copy link
Contributor

This implementation is not directly used for the push pool, but I am happy to port this change over

@JohnLemmonMedely
Copy link
Contributor Author

@zzstoatzz What do we need to merge this in?

@JohnLemmonMedely
Copy link
Contributor Author

@zzstoatzz or @jakekaplan what needs to be done to merge this PR in?

@jakekaplan
Copy link
Contributor

jakekaplan commented Feb 22, 2024

@JohnLemmonMedely apologies for the delayed reply! I missed your original message. I've updated and released the push pool implementation to match your implementation here. Will make sure this gets merged in tomorrow for workers/hybrid pools.

Copy link
Contributor

@jakekaplan jakekaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnLemmonMedely if you could merge in main and fix CHANGELOG.md that'd be great

@JohnLemmonMedely
Copy link
Contributor Author

@jakekaplan Thank you! I just dropped the CHANGELOG commit, it looks like it's been removed going forward?

@jakekaplan jakekaplan merged commit ea32a84 into PrefectHQ:main Feb 23, 2024
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vpc-access-connector error in Google Cloud Run Work Pool
3 participants