-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing server configs on hasura and towel deployments #346
fix missing server configs on hasura and towel deployments #346
Conversation
Hi! We can add this to the towel service, which indeed does consume some of the config values for Prefect Server. However, Hasura does not use our config so I don't see what including the environment variables there would do. Is there a specific issue that's resolving for you? (from the slack thread it seems like just towel needs the update) |
That's correct. Only Towel needs the update for my use case. I just thought that maybe it was also missing for Hasura, but if it's not used, I think that it's fine. |
Yeah their container won't do anything with those variables so we probably shouldn't include them. |
I've just removed it, thanks for saying that! |
@gabriel-milan thanks! Looks like you'll just need to get up to date with the |
does it seem correct? i'm not sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Thanks!
Summary
As I've spoken to @kvnkho on Slack, the Prefect Server configurations set on the
values.yaml
file are still missing on both Hasura and Towel deployments.Importance
This fixes misconfiguration for Hasura and Towel.
Checklist
This PR:
changes/
directory (if appropriate)