Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement empty listener for registerGDPRConsent hook #54

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Implement empty listener for registerGDPRConsent hook #54

merged 1 commit into from
Oct 19, 2020

Conversation

matthieu-rolland
Copy link
Contributor

Questions Answers
Description? From now on registered hooks must have a corresponding hook listener, the registerGDPRConsent is a special case, we implement an empty listener.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Partly fixes #19230
How to test? Check that the module can still be installed without error

@PierreRambaud PierreRambaud merged commit c1c864f into PrestaShop:dev Oct 19, 2020
@PierreRambaud
Copy link
Contributor

Thanks @matthieu-rolland

@PierreRambaud PierreRambaud added this to the 3.4.1 milestone Oct 19, 2020
@Progi1984 Progi1984 changed the title implement empty listener for registerGDPRConsent hook Implement empty listener for registerGDPRConsent hook Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4.0
3 participants
@matthieu-rolland @PierreRambaud @atomiix