Undefined array key 0 in Subject select input

[NicolasCador]

Questions	Answers
Description?	When you send a message through the PO in BO, then you send a new message trough Customer Service in BO, there is an error in Subject select input.
Type?	bug fix
BC breaks?	yes
Deprecations?	yes
Fixed ticket?	Fixes PrestaShop/PrestaShop#34672.
How to test?	Open an order in BO Send a message to customer Open Customer Service/Customer Service tab in BO Send a new message concerning this PO Open the customer e-mail, follow the link to answer It opens the Contact us page There isn't any error in the Subject select input

[NicolasCador]

hello @mflasquin,

ok, updated, thank you

[Hlavtox]

Use !empty(, it will be the cleanest. :)

[NicolasCador]

Hello @Hlavtox,

in fact we need to avoid 0 because array key 0 will be never defined.

And finally, @mflasquin, I'm not sure we need to put !== because with that, if $this->customer_thread['id_contact'] is different than int type, $contacts[$this->customer_thread['id_contact']] will also give an error.
What do you think?

[Hlavtox]

@NicolasCador Yes that is what empty will do. It will return true only if it's defined, not false, not null, not empty string, not zero. :-)

[NicolasCador]

hello @Hlavtox,

ok, thank you very much, I didn't know for 0, I updated

[florine2623]

Hello @NicolasCador ,

Tested your PR on PS 8.0.x, 8.1.3 and develop.
It works as expected. No more error on the Subject !

It is QA ✅

[Hlavtox]

Thanks everyone!