stop contact form process if there's an error in the controller

[aeyoll]

Questions	Answers
Description?	Prevent the contact form from being sent if there's an error in the controller. It allows a module to add additional form validation
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	-
How to test?	-

[Hlavtox]

Not sure about this. In my opinion, it's pretty annoying when you submit the form, it tells you an error, you fix it and it tells you another error. 🤷‍♂️

[aeyoll]

Your description matches how it works at the moment: if there are two errors in the form, only the first one is displayed. My PR displays all errors + display possible errors emitted by a module using a hook.

[Hlavtox]

@aeyoll Yes, you are right, I should see eye doctor. 😄😄😄

[boherm]

LGTM too, thanks @aeyoll ;)

[florine2623]

Hello @aeyoll

Could you provide a How to test for your PR please ?

Thanks!

[florine2623]

friendly reminder @aeyoll

[aeyoll]

Hello @florine2623,

You can test it by installing this module: https://github.com/aeyoll/pow-captcha-for-prestashop. It's a custom captcha module, it doesn't matter if its configured or not, since we want to test the failing case. It just need to be enabled.

Before the update of "contactform", you won't see the captcha error message. With this branch of "contactform", you'll see the captcha error message.

[florine2623]

Hello @aeyoll ,

Thanks for the details.

I tested the standard case.
All errors are displayed at once, instead of after each check.

It is QA ✅ !
Thanks!