Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic height + menu_photo resize #10

Open
wants to merge 3 commits into
base: sprites
Choose a base branch
from

Conversation

Peleg-Noam
Copy link

added height according to the height of the monitor (with room for the top bar)

added pygame.init()

Copy link
Owner

@Priyansh61 Priyansh61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Peleg-Noam
Thanks for your work. I just had a question.. can we do the same thing for the width of the window ??

I guess that would make the game more compatible by using dynamic witth..

@Priyansh61 Priyansh61 added the enhancement New feature or request label Jul 25, 2022
@Peleg-Noam Peleg-Noam changed the title dynamic height dynamic height + menu_photo resize Jul 25, 2022
@Peleg-Noam
Copy link
Author

I added the dynamic width.
However, in order to do so, I had to stretch the menu photo a bit (depending on the display size)…
I can revert it to the original size and center it on the screen if you'd like!

Also, by increasing the window width, isn't the game harder? because you need to stop more enemies at once

@Priyansh61
Copy link
Owner

Hey @Peleg-Noam

Really sorry for the late reply i guess you are right.. but i just had a doubt that if we increase the height of the window , the incomming speed of the ships is still the same , so won't it make the game a little boring...

So what can we do is that we can add a min and max height and make the dynamic height to remain in those parameters.

By doing this there will be no compatilbility issue for smaller display and game will also be not boring for bigger display.

Do let me know your feedback , and its really great discussing this issue with you..

@Peleg-Noam
Copy link
Author

Hi @Priyansh61!
I like the idea of adding a max width!
I do think that we can allow any height and change the speed of the ships accordingly...
great discussing this with you too :)

@Priyansh61
Copy link
Owner

Hey @Peleg-Noam

Was busy in some college work , i am deeply sorry for such a late reply.

Could you make some commits in the above code deploying the changes , and do let me know if you need any help.

Always there to help....

@Priyansh61 Priyansh61 closed this Aug 20, 2022
@Peleg-Noam
Copy link
Author

Hi there @Priyansh61 , Im really sorry but I didn't see that you commented back...
I'll get to it tomorrow!
Glad to be working on this with you again 🙂

@Priyansh61 Priyansh61 reopened this Aug 21, 2022
@Priyansh61
Copy link
Owner

Great to see you back @Peleg-Noam 😃

Hope you are doing great, let's work on this issue and do let me know if i can help you in any way... 👍

@Peleg-Noam
Copy link
Author

Hi there!
I made the enemy screen dynamic, hope it fits.
I was thinking that maybe we could add a global variable to all the "stats" to make them compatible with the screen height and width. Like increasing or decreasing the speed of the player, laser et cetera...

@Priyansh61
Copy link
Owner

Hey @Peleg-Noam

It was a great experience playing the game on the full screen and i enjoyed playing it on larger resolution but i just had a question can we do something to stop the menu image from distorting.

The main menu image gets distorted and some of its content is not visible due to this, so how can we fix this issue??

@Priyansh61
Copy link
Owner

@Peleg-Noam Any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants