Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<blockquote> not working #222

Closed
Leader-board opened this issue Apr 10, 2021 · 7 comments
Closed

<blockquote> not working #222

Leader-board opened this issue Apr 10, 2021 · 7 comments
Labels

Comments

@Leader-board
Copy link

Leader-board commented Apr 10, 2021

Contrast https://www.betaarchive.com/wiki/index.php?title=WinFS with https://www.betaarchive.com/wiki/index.php?title=WinFS&useskin=vector

The article has many instances of < blockquote >, which don't seem to work as expected in Chameleon.

@malberts
Copy link
Contributor

malberts commented Apr 10, 2021

Can you explain what you were expecting?

The first thing to note is Chameleon is not applying Bootstrap's blockquote class to the default <blockquote> tags. However, the default Bootstrap styling explicitly resets the default margin (see here) and then merely changes the font and bottom margin. For example (latest Bootstrap+Chameleon):
image
The first one is with just <blockquote> the second one is <blockquote class="blockquote"> (as per Bootstrap documentation).

If you were expecting a left margin, then you need to add it yourself. I am not sure if the Chameleon skin should undo the Bootstrap reset.

@Leader-board
Copy link
Author

Leader-board commented Apr 10, 2021

As per https://www.mediawiki.org/wiki/Help:Formatting - it clearly specifies there that blockquote includes a left indentation, and that is what I was expecting as a result.

@malberts
Copy link
Contributor

malberts commented Apr 10, 2021

If you want to undo Bootstrap's stylistic decision you can add the following CSS to add the margin back to all <blockquote> tags without the explicit Bootstrap class.

blockquote:not([class]) {
    margin: 1em 40px;
}

@Leader-board
Copy link
Author

If you want to undo Bootstrap's stylistic decision you can add the following CSS to add the margin back to all <blockquote> tags without the explicit Bootstrap class.

blockquote:not([class]) {
    margin: 1em 40px;
}

Hi, it works now, thanks for helping. That being said, I personally think this should be default, as MediaWiki documentation explicitly expects indentation.

@sophianyberg
Copy link

Can we close this issue? It seems to be resolved.

@Michael-Z-Freeman
Copy link

Also think the mediawiki blockquote should be the default as its unexpected. I initially thought something had broken and not that its just Bootstrap styling. Cheers.

@Michael-Z-Freeman
Copy link

Michael-Z-Freeman commented Aug 8, 2022

How do I also restore the grey bar down the left hand side of the block quote ?

EDIT: Oh, got it ...

blockquote:not([class]) {
    margin: 1em 40px;
    border-left: 4px solid #eaecf0;
    padding: 8px 32px;
}

flexiondotorg added a commit to flexiondotorg/flexiondotorg.github.io that referenced this issue Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants