Remove 'mediawiki.ui.button' from ResourceLoader #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line generates an error in the Javascript console: > Special:Version:200 This page is using the deprecated ResourceLoader module "mediawiki.ui.button". > [1.41] Please use Codex. See migration guidelines: https://w.wiki/7TAh And does not appear to be used by chameleon skin in any case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed one line which was generating an error in the Javascript console:
Unless I am missing something, mediawiki.ui.button is not used by current version of chameleon skin in any case.
This edit removes it from the ResourceLoader.