Core: fix bug where the PBS adapter always times out (prebid#10501)

PubMatic-OpenWrap · Oct 10, 2023 · a21ca1c · a21ca1c
1 parent 9501632
commit a21ca1c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/adapterManager.js b/src/adapterManager.js
@@ -422,7 +422,7 @@ adapterManager.callBids = (adUnits, bidRequests, addBidResponse, doneCb, request
             bidRequest.start = timestamp();
             return function () {
               onTimelyResponse(bidRequest.bidderRequestId);
-              doneCbs.apply(bidRequest, arguments);
+              doneCb.apply(bidRequest, arguments);
             }
           });
 

diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js
@@ -965,13 +965,23 @@ describe('adapterManager tests', function () {
     }];
 
     it('invokes callBids on the S2S adapter', function () {
+      const done = sinon.stub();
+      const onTimelyResponse = sinon.stub();
+      prebidServerAdapterMock.callBids.callsFake((_1, _2, _3, done) => {
+        done();
+      });
       adapterManager.callBids(
         getAdUnits(),
         bidRequests,
         () => {},
-        () => () => {}
+        done,
+        undefined,
+        undefined,
+        onTimelyResponse
       );
       sinon.assert.calledTwice(prebidServerAdapterMock.callBids);
+      sinon.assert.calledTwice(done);
+      bidRequests.forEach(br => sinon.assert.calledWith(onTimelyResponse, br.bidderRequestId));
     });
 
     // Enable this test when prebidServer adapter is made 1.0 compliant