Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare support for Python 3.13 #487

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Declare support for Python 3.13 #487

merged 2 commits into from
Jun 12, 2024

Conversation

AlexWaygood
Copy link
Collaborator

No description provided.

This comment has been minimized.

@JelleZijlstra
Copy link
Collaborator

  + /home/runner/work/flake8-pyi/flake8-pyi/pyi.py:1484: DeprecationWarning: Tuple.__init__ missing 1 required positional argument: 'ctx'. This will become an error in Python 3.15.

This will go away in the next beta. We could just add ctx=ast.Load() though to make things work now.

@AlexWaygood
Copy link
Collaborator Author

AlexWaygood commented May 10, 2024

I think I'm inclined to keep our code how it is and wait for the next beta (scheduled to arrive in just over two weeks, and I think Thomas might be planning to expedite it even more due to some bugfixes that didn't quite make it into beta1). I'll just keep this as a draft for now.

This comment has been minimized.

@AlexWaygood
Copy link
Collaborator Author

AlexWaygood commented Jun 10, 2024

Well, the latest update is that Python 3.13.0b2 is now available on setup-python, but the build they provide is apparently utterly broken:

(The issue title says "3.12", but the discussion in the issue notes that the problem occurs for 3.13.0b2 as well.)

@AlexWaygood
Copy link
Collaborator Author

Tests all pass locally for me with 3.13.0b2, though, so I guess I'll mark as "ready for review"

@AlexWaygood AlexWaygood marked this pull request as ready for review June 10, 2024 09:47
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once CI passes.

@AlexWaygood AlexWaygood reopened this Jun 12, 2024
Copy link

This change has no effect on typeshed. 🤖🎉

@AlexWaygood AlexWaygood merged commit fa50d65 into main Jun 12, 2024
42 of 46 checks passed
@AlexWaygood AlexWaygood deleted the 313 branch June 12, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants