Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: restyling of Kirchhoff operator #528

Closed
wants to merge 16 commits into from

Conversation

mrava87
Copy link
Collaborator

@mrava87 mrava87 commented Sep 30, 2023

This PR introduces a number of changes to the Kirchhoff operator in an attempt to improve the amplitude fidelity of this modelling process with respect to finite-difference full wavefield modelling. Also follows from #439.

Major changes:

  • Remove anglerefl as the angle theta can be computed directly from the incident and reflection angles with normal
  • Remove snell limitations, this is naturally handled by stationary-phase when summing along all possible image points and src-rec pairs
  • Force amp to be provided as pair of tables like trav
  • When amp is not provided, compute it as 1/sqrt(dist) for both source and receiver side in 2D (and 1/dist in 3D)
  • Correct computation of cos(\theta)
  • Documentation polished and fully consistent with code

@mrava87 mrava87 closed this Oct 1, 2023
@mrava87 mrava87 deleted the feature-kirchhoffrestyle branch October 1, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant