-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid private methods when adding unused Parameter
s
#34
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
fixes: | ||
- | | ||
The internal-only method of handling circuits that define a parameter that they do not use | ||
(such as a program that defines ``input float a;`` but doesn't use ``a``) has changed to | ||
avoid using private Qiskit methods. This makes it more resilient to changing versions | ||
of Qiskit. | ||
upgrade: | ||
- | | ||
OpenQASM 3 inputs that include ``input float`` parameters that are not used by the program | ||
will now parse to circuits that have a global phase that appears parametrised in terms of | ||
the otherwise-unused parameter. The numerical value of the global phase will not be affected, | ||
and the global phase will be independent of the parameters. You can discard the parameter | ||
by using ``QuantumCircuit.assign_parameters`` to assign any numeric value to the parameter. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this potentially does change the type of global phase from a float to parameter expression in Qiskit which is a bit unfortunate. But it should be normalized away if somebody does anything that uses the circuit for anything and global phase gets cast as a float.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it does, and what's worse, it makes the global phase compare unequal to 0 (because of the parametrisation). But it should only actually appear for OQ3 programs like
where
a
isn't used, and I think storing the dummy reference in the global phase is probably less disruptive than adding a dummy gate to hold it.