fix(workbook): fix abs path /xl/worksheets/sheet1.xml -> xl/worksheets/sheet1.xml #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantti
reviewed
May 10, 2024
dantti
reviewed
May 10, 2024
stolen-programmer
force-pushed
the
dev
branch
2 times, most recently
from
8795189
to
e6f9dd6
Compare
dantti
requested changes
Jul 4, 2024
QXlsx/header/xlsxworksheet.h
Outdated
| @@ -192,6 +192,9 @@ class QXLSX_EXPORT Worksheet : public AbstractSheet | |||
| private: | |||
| void saveToXmlFile(QIODevice *device) const override; | |||
| bool loadFromXmlFile(QIODevice *device) override; | |||
|
|
|||
| public: | |||
| const QList<CellRange> &editRegion() const; | |||
There was a problem hiding this comment.
Please change to:
QList editRegion() const;
as const & return in Qt containers is not needed
There was a problem hiding this comment.
also since this is plublic plese move upwards and leave a description documenting it
QXlsx/source/xlsxworksheet.cpp
Outdated
| // 跨多列 | ||
| if (pos.column() - cellRange.firstColumn() < -1 || | ||
| pos.column() - cellRange.lastColumn() > 1 || // 跨多列 | ||
| // 跨多行 |
There was a problem hiding this comment.
Please leave comments in english.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix abs path /xl/worksheets/sheet1.xml -> xl/worksheets/sheet1.xml