Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batching, protocol asset tracking, and ratio withdrawals #28

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

jakekidd
Copy link
Contributor

@jakekidd jakekidd commented Jun 20, 2024

  • Have changed 'execute' to 'open'
  • Now have batch struct input for open and close: stores protocol and amount
  • Now track protocol assets stored locally, child contracts are expected to pass their asset (e.g. LP tokens, aTokens, etc) back to QWManager. Note that this will be different for staking, however, as no tokens are returned...
  • We do ratio withdrawals. Since user ownership % of the investment pool for a given protocol will be the thing we track off-chain, we now withdraw not in amount of tokens but in % of the total pool.
  • Every protocol now has a designated "investment token" which is expected to be given to purchase LP tokens for example, and expected to be the token received when we withdraw, making it also the liquidation token

In line with spec: https://docs.google.com/document/d/1ph0YBSK93mUuKtnnJqtEYL87gR_my0SHbYOpzvA0wdI/edit

@jakekidd jakekidd changed the title Implement shares for value tracking of user investments on-chain Implement batching, protocol asset tracking, and ratio withdrawals Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant