Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code portability #59

Open
pcosme opened this issue Apr 26, 2021 · 2 comments
Open

Code portability #59

pcosme opened this issue Apr 26, 2021 · 2 comments

Comments

@pcosme
Copy link
Collaborator

pcosme commented Apr 26, 2021 •
edited
Loading

So far, the compilation of the code has been tested mainly on Fedora systems and Ubuntu in some cases. We should take care to the compilation procedure to be functional in several Unix systems such as mac os.
@pcosme
Copy link
Collaborator Author

pcosme commented Apr 26, 2021

It has come to my attention that in de Ian based systems the cmake list should explicitly set include_directories(${HDF5_INCLUDE_DIRS})

pcosme added a commit that referenced this issue Apr 27, 2021
@pcosme
Update CMakeList.txt as discussed in #59
095e857 
(cf. issue #59 ) we now force the cmake to include the appropriate directories of HDF5
@pcosme
Copy link
Collaborator Author

pcosme commented Apr 30, 2021

in some unix systems (ubuntu, mint and macOS) it seems that the cmake becomes a bit confused at first, not having the tethys_library already archived at the ./lib directory, this can be overcome by running make tethys_library between cmake configuration.

More serious is the situation with the openmp and clang on macos which i haven't yet found a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pcosme