Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix malformed www-authenticate issue #88

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix malformed www-authenticate issue #88

merged 1 commit into from
Jul 9, 2024

Conversation

Bdegraaf1234
Copy link
Member

Our WWW-Authenticate headers were incorrectly formatted, reading

     WWW-Authenticate: Bearer realm="example" error="invalid_token" error_description="The access token expired"

instead of

     WWW-Authenticate: Bearer realm="example", error="invalid_token", error_description="The access token expired"

According to the oauth2 spec and the HTTP spec.

This should fix the error

@Bdegraaf1234 Bdegraaf1234 self-assigned this Jul 5, 2024
@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Jul 5, 2024
Merged
pvannierop
pvannierop approved these changes Jul 9, 2024
View reviewed changes
Copy link

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bdegraaf1234 Bdegraaf1234 merged commit eec126b into dev Jul 9, 2024
1 check passed
@Bdegraaf1234 Bdegraaf1234 deleted the fix/malformed-www-authenticate-header branch July 9, 2024 11:03
@Bdegraaf1234 Bdegraaf1234 mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvannierop pvannierop pvannierop approved these changes

@yatharthranjan yatharthranjan Awaiting requested review from yatharthranjan

@mpgxvii mpgxvii Awaiting requested review from mpgxvii

Assignees

@Bdegraaf1234 Bdegraaf1234

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bdegraaf1234 @pvannierop