Improvements to sequence features #627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does several things: - Move accession column out of rnc_sequence_features, to work better with storing Rfam hits and corrects the representation of the features. - Rename rnc_sequence_features_id to rnc_sequence_feature_id. That name is weird and reads wrong - Rename start/stop to start_index/stop_index. I think we should start using something like _index or some other term to indicate that this is a zero based field - Renames the column upi to urs. We should use this id every where and this is just one step to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does several things:
Move accession column out of rnc_sequence_features, to work better with storing Rfam hits and corrects the representation of the features.
Rename rnc_sequence_features_id to rnc_sequence_feature_id. That name is weird and reads wrong
Rename start/stop to start_index/stop_index. I think we should start using something like _index or some other term to indicate that this is a zero based field
Renames the column upi to urs. We should use this id every where and this is just one step to that.
It's worth discussing if these are good ideas for our database.