Migrated from Docopt to ArgParse #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
calexandru2018
commented
Jun 29, 2020
calexandru2018
commented
- The CLI has been fully migrated to ArgParse
- CLI code has been written in OO paradigm
- None of the commands have been changed, fully backwards compatible with the previous version using Docopt
Have also added a custom help message.
Restored some CLI commands so that they are fully compatible with previous versions
calexandru2018
commented
Jun 29, 2020
calexandru2018
commented
Jun 29, 2020
Rafficer
requested changes
Jul 1, 2020
kaplun
approved these changes
Jul 3, 2020
|
docopt is still mentioned as dependency in setup.py and requirements.txt. 😜 |
Rafficer
approved these changes
Jul 3, 2020
Galiley
pushed a commit
to Galiley/linux-cli-community
that referenced
this pull request
Dec 15, 2020
* Ported CLI to argparse, based on OO programming paradigm * Added descriptive comments * Updated usage string * Added logging * Updated exmaples * Removed function based CLI code * Removed docopt dependency * Added usage constant * Added back the PVPN_WAIT environment variable * Addressed Flake8 issues * Examples are now inline with the CLI * Removed unncesessary comment * Cleaned up code and improved readability * Removed dependencies still they are no longer needed * Updated inline command * Allow uppercase protocol with -p * Allign help message * Return missing -p to example Co-authored-by: Alexandru Cheltuitor <[email protected]>
|
The second to last commit was force-pushed and ignored this PR which was previously merged. I was wondering if that was intentional to revert this back? Getting back to Docopt again? |
|
We are preparing the official linux CLI (currently on beta: https://protonvpn.com/blog/linux-vpn-cli-beta/). For technical reasons (as we need to prepare for smooth update from this CLI to the official one) we needed to make a small technical release as part of the planned upgrade. Unfortunately master branch already had this docopt-to-argparse branch merged in, but was too risky to make the technical release to also include this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.