few changes in MainActivity.java of p8

Raghuvorkady · Jun 23, 2021 · baf9a4d · baf9a4d
1 parent 8ceacc2
commit baf9a4d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 26 deletions.
diff --git a/p8-CallAndSaveApp/app/build.gradle b/p8-CallAndSaveApp/app/build.gradle
@@ -8,8 +8,8 @@ android {
         applicationId "csmp.part_a.p8"
         minSdkVersion 14
         targetSdkVersion 30
-        versionCode 3
-        versionName "1.1.1"
+        versionCode 4
+        versionName "1.1.2"
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }

diff --git a/p8-CallAndSaveApp/app/src/main/java/csmp/part_a/p8/MainActivity.java b/p8-CallAndSaveApp/app/src/main/java/csmp/part_a/p8/MainActivity.java
@@ -21,7 +21,7 @@
 
 public class MainActivity extends AppCompatActivity implements View.OnClickListener, View.OnLongClickListener {
 
-    private static final int REQUEST_CODE_ASK_PERMISSIONS = 1;
+    private static final int REQUEST_CODE = 1;
     private TextView expressionTextView;
 
     private Vibrator vibrator;
@@ -71,7 +71,7 @@ protected void onCreate(Bundle savedInstanceState) {
         saveBtn.setOnClickListener(this);
 
         vibrator = (Vibrator) getApplicationContext().getSystemService(Context.VIBRATOR_SERVICE);
-        requestPermission();
+        requestPermissionFromUser();
     }
 
     @SuppressLint("NonConstantResourceId")
@@ -132,6 +132,27 @@ public void onClick(View view) {
         }
     }
 
+    private void requestPermissionFromUser() {
+        String permission = Manifest.permission.CALL_PHONE;
+        String[] permissions = new String[]{permission};
+        if (ContextCompat.checkSelfPermission(this, permission) != PackageManager.PERMISSION_GRANTED) {
+            ActivityCompat.requestPermissions(this, permissions, REQUEST_CODE);
+        }
+    }
+
+    @Override
+    public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
+        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
+        if (requestCode == REQUEST_CODE) {
+            if (grantResults[0] == PackageManager.PERMISSION_GRANTED)
+                makeToast("Permission Granted");
+            else
+                makeToast("Permission Denied");
+        } else {
+            super.onRequestPermissionsResult(requestCode, permissions, grantResults);
+        }
+    }
+
     private void saveMethod(String inputPhoneNo) {
         Intent intent = new Intent(ContactsContract.Intents.Insert.ACTION);
         intent.setType(ContactsContract.RawContacts.CONTENT_TYPE);
@@ -148,28 +169,6 @@ private void callMethod(String number) {
         startActivity(intent);
     }
 
-    private void requestPermission() {
-        String permissionString = Manifest.permission.CALL_PHONE;
-        String[] permissionStringArray = new String[]{permissionString};
-        if (ContextCompat.checkSelfPermission(this, permissionString) != PackageManager.PERMISSION_GRANTED) {
-            ActivityCompat.requestPermissions(MainActivity.this, permissionStringArray, REQUEST_CODE_ASK_PERMISSIONS);
-        }
-    }
-
-    @Override
-    public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
-        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
-        if (requestCode == REQUEST_CODE_ASK_PERMISSIONS) {
-            if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {// Permission Granted
-                makeToast("Permission Granted");
-            } else { // Permission Denied
-                makeToast("Permission Denied");
-            }
-        } else {
-            super.onRequestPermissionsResult(requestCode, permissions, grantResults);
-        }
-    }
-
     private void makeToast(String toastMessage) {
         Toast.makeText(getApplicationContext(), toastMessage, Toast.LENGTH_SHORT).show();
     }