Windows support #83
Merged
Windows support #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meReader to get media frames
|
@Redth Would you have a moment to review this PR? |
|
Hi guys, |
Open
Redth
approved these changes
Oct 23, 2023
|
Hello, I'd like to ask is the merging of this pull request means that the barcode reader will be supported on Windows now? Or does it need something more to fully function? |
|
Understood, thank you! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
I added Windows support for an application of mine.
It's mainly based on documentation found at https://learn.microsoft.com/en-us/windows/uwp/audio-video-camera/process-media-frames-with-mediaframereader, as a replacement for the CaptureElement.
I tested it with an USB camera, although the camera doesn't support focus and torch features, so that related part is still untested.
This PR may require additional code clean-up and refactoring as suggested by any possible review.
For example, it supports autodetection of camera connection and disconnection: the original CaptureElement seems to not support this feature, so it may be removed from this PR to keep the code aligned to CaptureElement behaviour (and autodetection code may be moved at application level).
The relevant file is CameraManager.windows.cs.
Let me know if this PR may be useful as a Windows starting point; feel free to close it if not needed.
Regards