[bug fix] added num_gpus variable to ray init call #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use my GPU (with the devcontainer setup) I needed to add the
num_gpusvariable to theray.init()call.Bug behavior
Whenever I set
num_gpus> 1, I got a Ray error stating that no nodes/resources were available that fit my request. After the proposed changes, this error did not occur anymore.Beware
If Ray auto-detected the GPUs available on your server before, this probably shouldn't interfere with this auto-detection. But I don't have the setup to test this. So please try if your GPUs are still autodetected with the proposed changes - in case you used GPUs.
For the future
Maybe there should be additional tests for
num_gpus> 1 behavior. However, they obviously only make sense for a setup that has GPUs.