Fixed: impossible to generate exception classes for non-first client #4891
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
…n-first OpenApiReferences, but make it possible to override that using MSBuild properties
|
Personally I do not use this functionality. Are you sure that this does not introduce regressions? |
|
I'm pretty confident this is safe to take, I've tested various scenarios. I understand your concerns and am happy to help out in case regressions surface. I've been a professional .NET developer for 20 years. This change and #4891 are blocking us from adopting v14. Please let me know what I can do get this merged. |
|
Hard to say for me, but dont think it's a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4890.