Add warning message to controller docs about automatic SDL_GameControllerClose call on drop #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich happens on `GameController` drop.
…_GameControllerClose call.
|
I don't really feel like it's that necessary. I don't mind merging it but it's pretty much in line with everything else in Rust that use structs like File, UdpSocket, AudioStream, etc close their resources when they are dropped. Are you new to Rust by any chance? |
|
I see, makes sense. I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case nobody wastes their time wondering why controller events are not being fired if they initialize controllers in a scope that destroys the opened controller instances on exit.