Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static linking windows "fix" #876

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

dmitsuki
Copy link

Static linking didn't work on Windows. It should work on this build.

#864

@Cobrand
Copy link
Member

Cobrand commented Apr 1, 2019

I don't get it. There are literally no changes?

@dmitsuki
Copy link
Author

dmitsuki commented Apr 1, 2019

I'm honestly just as confused as you. I didn't really post this PR for it to actually be merged, but so people can see it and see if windows runs under this build. The only thing this build did was add in a line, and then remove that same line over 2 commits. It's worth noting that it did not work on either of my windows 10 builds, and worked in this build. The actual file is correct, but the line
println!("cargo:rustc-link-lib=shell32");
gets omitted from the build. I can see no reason in the code why this happens, and it also doesn't happen after I added that comment, and it also did it happen after REMOVING said comment.

@Cobrand
Copy link
Member

Cobrand commented Apr 1, 2019

Does cargo clean fix your issue with the master branch?

@dmitsuki
Copy link
Author

dmitsuki commented Apr 1, 2019

Well, just started new project with master branch, added it to cargo.toml, ran it (didn't run cargo clean) and bug is not reproducible, but when I tried it the other day (on similarly clean projects) it didn't compile. For now because I cannot reproduce it, I can't test if clean would fix it, but if it ever happens again I'll try to clean it. I'm wondering if there is some windows stetting or something that caused me and the other user to experience this. I'm honestly scratching my head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants