-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installer migration #6
Fix installer migration #6
Conversation
@S0ly why did you ping me without a message? |
|
||
// DB Migration & APP_KEY Generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont get why instread of fixing the bug you created a totally new form that is not really needed ?
I don't know why my GitHub is bugged |
I was saying I dont get why instread of fixing the bug you created a totally new form that is not really needed ? |
I tried "fixing the bug" but apparently when setting the env variables AND trying to access it instantly (in the same form for the migration) it doesnt really work. probably because the state is not updated yet. |
have you tried to add a sleep for like 3 seconds ? |
I tried to add a sleep for 1s but that should be plenty of time to set a env variable |
So what is happening with this now? |
you didnt told me if adding a sleep fixed the problem ? is there a more simple less overkill solution than creating a new form ? |
I already told you at least twice that a sleep of 1s didnt solve it. And 1s should be plenty of time for this.
yes, creating the |
since checkDB step set all the env value related to DB maybe yes it could be great to merge it whit this step :) |
Alright will do, maybe i find the time today. I will let you know here when i am done. |
Updated it so it will generate the |
you tested it and it work ? |
my GitHub have the review process that is glitched I dont know why :( |
Yes tested it for normal case and for a exception case. both worked. |
okay :) thanks you |
generateKey
form topublic/install/forms.php
because the env variable apparently isnt being loaded properly if the key generation and database migration is in one form. And the DB migration needs theAPP_KEY
loadedpublic/install/index.php
. But the only new stuff happened from Line 233.