Fix installer migration

[jameskitt616]

• I added a new generateKey form to public/install/forms.php because the env variable apparently isnt being loaded properly if the key generation and database migration is in one form. And the DB migration needs the APP_KEY loaded
• I formatted a few Lines in public/install/index.php. But the only new stuff happened from Line 233.

[S0ly]

@jameskitt616

[jameskitt616]

@S0ly why did you ping me without a message?

[S0ly]

I dont get why instread of fixing the bug you created a totally new form that is not really needed ?

[S0ly]

I don't know why my GitHub is bugged

a

[S0ly]

I was saying I dont get why instread of fixing the bug you created a totally new form that is not really needed ?

[jameskitt616]

I tried "fixing the bug" but apparently when setting the env variables AND trying to access it instantly (in the same form for the migration) it doesnt really work. probably because the state is not updated yet.
I tried to fix it with updating the env variables manually and clearing the settings cache via laravel command during runtime, but it didnt work.
If you got a better idea how to fix it, or know laravel better than i do, i am glad to have some help.
(i also don't think it's to bad to have an extra form for this, but i do agree that it's kinda weird to have)

[S0ly]

have you tried to add a sleep for like 3 seconds ?

[jameskitt616]

I tried to add a sleep for 1s but that should be plenty of time to set a env variable

[jameskitt616]

So what is happening with this now?

[S0ly]

you didnt told me if adding a sleep fixed the problem ? is there a more simple less overkill solution than creating a new form ?

[jameskitt616]

I already told you at least twice that a sleep of 1s didnt solve it. And 1s should be plenty of time for this.

is there a more simple less overkill solution than creating a new form ?

yes, creating the APP_KEY in the previous step should do the trick as well.
Should i do that?

[S0ly]

since checkDB step set all the env value related to DB maybe yes it could be great to merge it whit this step :)

[jameskitt616]

Alright will do, maybe i find the time today. I will let you know here when i am done.

[jameskitt616]

Updated it so it will generate the APP_KEY now in the database setup. Please review the MR.

[S0ly]

you tested it and it work ?

[S0ly]

my GitHub have the review process that is glitched I dont know why :(

[jameskitt616]

Yes tested it for normal case and for a exception case. both worked.

[S0ly]

okay :) thanks you