Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass env variables to GITHUB_ENV after definition #234

Open
CasperWA opened this issue Jan 13, 2024 · 0 comments
Open

Pass env variables to GITHUB_ENV after definition #234

CasperWA opened this issue Jan 13, 2024 · 0 comments
Labels
GH Workflows Issue/PR related to the callable workflows good first issue Good for newcomers priority/low Low priority issue/PR

Comments

@CasperWA
Copy link
Collaborator

Springing from this discussion in #233 I think it makes sense to first define the variables in plain bash style and then afterwards define the variable in the GITHUB_ENV variable.

This should make for more readable lines in the callable workflows, which are not natively bash scripts, but rather YAML files.
@CasperWA CasperWA added good first issue Good for newcomers GH Workflows Issue/PR related to the callable workflows priority/low Low priority issue/PR labels Jan 13, 2024
CasperWA added a commit that referenced this issue Jan 13, 2024
@CasperWA
Go through another env var to set --since-tag (#233)
862c085 
Add a space in GitHub actions variables where there was none to make
them look more proper.

Define env var in GITHUB_ENV after proper definition.
An issue has been raised to do this in every place for all workflows,
see #234.

This is done as part of the code review by @DanielMarchand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GH Workflows Issue/PR related to the callable workflows good first issue Good for newcomers priority/low Low priority issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CasperWA