Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug preventing broadcast to all #1192

Merged

Conversation

CSDSP
Copy link

@CSDSP CSDSP commented Aug 18, 2024

About The Pull Request

Fixes a long-standing bug. NTNet transmitters are supposed to be able to transmit to all others, but a single-line bug prevented it.

Why It's Good For The Game

Being able to send to all other NTNet receivers is a useful thing for making circuits involving many individual parts, and was an originally intended feature.

A Port?

Fixed this a while ago on the Syndication downstream, with TheSyndication@eebe529
This is just a cherry-pick of that commit.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
fix: NTNet broadcast to all
/:cl:

@MosleyTheMalO MosleyTheMalO merged commit d7fd48f into SPLURT-Station:master Aug 18, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 18, 2024
@SpaceCheetah SpaceCheetah deleted the fix-broadcast-upstream branch August 18, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants