Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem computers #1193

Merged

Conversation

CSDSP
Copy link

@CSDSP CSDSP commented Aug 24, 2024

About The Pull Request

Fixes a couple bugs with Problem Computers.
Specifically, rounds the expected answer in easy algebra (it stood out as the only not-rounded problem),
and fixes the line intersection problem.

Why It's Good For The Game

Makes the line intersection problem actually work, instead of being unsolvable. This is a pretty major frustration when using problem computers, since you always have to skip them.

A Port?

No

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
fix: Rounding in Problem Computer easy algebra
fix: Expected answer in Problem Computer line intersection
refactor: removes duplicated code
/:cl:

@MosleyTheMalO MosleyTheMalO merged commit 56186dc into SPLURT-Station:master Aug 25, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 25, 2024
@SpaceCheetah SpaceCheetah deleted the fix-problemcomputer branch August 26, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants