Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more exploding abandoned crates. #1197

Closed
wants to merge 4 commits into from

Conversation

Zeddersds
Copy link

@Zeddersds Zeddersds commented Sep 1, 2024

About The Pull Request

Abandoned crates doesn't explode anymore and you have infinite tries do decode it, also you can't destroy it.

Why It's Good For The Game

No boom, no station destruction, which is good.

A Port?

Nope i did it my self

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

/:cl:

Makes crate pop instead of explosion
Forgot change one line, now its will not boom in any situations
@Zeddersds Zeddersds marked this pull request as draft September 1, 2024 19:12
@Zeddersds Zeddersds marked this pull request as ready for review September 1, 2024 19:14
@Zeddersds Zeddersds marked this pull request as draft September 1, 2024 19:14
@Zeddersds
Copy link
Author

Zeddersds commented Sep 1, 2024

Though crate just pops now without harming station, its content doesn't dissapear, if someone know how to fix that that would be great.

@Zeddersds
Copy link
Author

I tried use a bit of code from displaycase.dm to solve this issue but it didn't worked.

@Zeddersds
Copy link
Author

By some sheer stupidity i had, i somehow made crates instead of poping and exploding just invincible.

@Zeddersds
Copy link
Author

Okay so by far after i did some code diving and test on local server its kinda working now

@Zeddersds Zeddersds marked this pull request as ready for review September 1, 2024 22:04
@Zeddersds
Copy link
Author

A bit more testing and there 0 runtimes on local server with changes i did so all fine for sure.

@Zeddersds
Copy link
Author

@MosleyTheMalO atleast say something what wrong again jesus. This pull request wasn't even not that bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants