Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Migration feature #37

Merged
merged 17 commits into from
May 24, 2020
Merged

Database Migration feature #37

merged 17 commits into from
May 24, 2020

Conversation

khdevnet
Copy link

Hello @SRoddis @thiagoadril,

I have found that people looking for Database level migrations libraries and also
I use mongo migration library on the current project and we need to insert new documents from file some times, I want to use migrations for this, I have created a Pull request which enables Database level migrations.

I have updated existing naming for migrations and add Database migration functionality
MongoMigration

I can continue to work on this topic
list of things what not finished:

  • continue manual testing
  • write Unit Tests
  • test database migrations when no document migrations

Is the following feature interesting for you?

@khdevnet khdevnet mentioned this pull request Apr 26, 2020
@SRoddis
Copy link
Owner

SRoddis commented Apr 27, 2020

Yes, you are welcome to work on the project.

It is just importand that you write unit tests, check the performance and add documentation for the feature. Sounds good. :)

Cheers, Sean

@RoyalTux
Copy link

Hello @khdevnet ,

It's a very good idea to implement this feature and tests. I need this functionality in my project too. Thank you for your work!

Best regards, Dmitriy

@khdevnet
Copy link
Author

khdevnet commented May 2, 2020

Yes, you are welcome to work on the project.

It is just importand that you write unit tests, check the performance and add documentation for the feature. Sounds good. :)

Cheers, Sean

Hello @SRoddis ,

I have added tests and update documentation.

I didn't write performance tests because I don't know what cover with them, in case of database migration, performance depends on how you write your migration.

@SRoddis
Can you please review my latest changes and let me know what I left to do to finalize the current Pull request?

@johnnyswan
Copy link

Hey, guys, we're just looking for a similar tool for our project. Good idea.

@SRoddis SRoddis merged commit b59c15b into SRoddis:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants