Refactor permissionsCheck and test

[YotaYota]

Refactored permissionsCheck.js and added test file permissionsCheck.test.js.

[YotaYota]

I noticed 2 things about permissions that's worth noticing:

• methods and endpoints on the permissions object are not used
• Since permission check just loads from local storage, I guess a user can modify it to see more things (I guess there's a check in backend as well)? 😱

But I've been looking at local storage in norpan; and there is no "permissions" set there, so there's probably a part of the puzzle that I've missed.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[indy-independence]

methods and endpoints are only used by the python API I think, and the things saved in local storage is only what menus to display it doesn't control what you actually can do so I think it's fine like that
@Josephine-Rutten maybe has input on the refactor things?

[Josephine-Rutten]

Yeah indeed, at first the idea was to use methods and endpoint on the front and backend, but working with pages and permissions on the frontend seems a bit more user friendly. We could filter this out in the backend so we don't give back methods and endpoints, but might also be useful when debugging. If you see an improvement here, please let me know.

The real permission checks happen in the backend, in the frontend the goal is mostly to make sure the user doesn't see options that they can't use.

The refactor looks great, haven't tested it, but big code improvement and great to have some unit testing as well.