This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Bump react-scripts to v5 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
commented
May 11, 2022
Comment on lines
-199
to
+206
| onHide={handleCloseLoginDialog} | ||
| onHide={() => { | ||
| handleCloseLoginDialog() | ||
| }} |
There was a problem hiding this comment.
Fixes a linting error where the type of handleCloseLoginDialog didn't match the permitted type of onHide
jay-hodgson
approved these changes
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While craco isn't currently actively maintained, I think it's still worth using it to upgrade to react-scripts v5. We may be able to just use plain react-scripts in the future, depending on whether facebook/create-react-app#11764 (or similar PR) is merged.