Add support for Logitech G433 (Sidetone) #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it is identical, please just add the productID of your G433 to the file of G432 at PRODUCT_IDS |
|
Ok, probably bad phrasing on my side: It's not some kind of "upgraded" G432, it's a completely different look and feel. However since sidetone setting seems to work identical I'll just merge those two ;) |
|
Yeah there are often headsets with same protocol. The sense of the source files is practically not to group headsets, but to group protocols and code. Otherwise we would have double code, and additional effort and error sources |
rpbaptist
pushed a commit
to rpbaptist/HeadsetControl
that referenced
this pull request
May 31, 2024
* Add support for Logitech G433 (Sidetone)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for the Logitech G433 headset (sidetone). This is basically the same thing as G432, just copied the files and swapped out names and USB ID. Tested only on Linux.