Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.0 #1

Merged
merged 7 commits into from
Oct 8, 2022
Merged

3.2.0 #1

merged 7 commits into from
Oct 8, 2022

Conversation

somehybrid
Copy link
Contributor

@somehybrid somehybrid commented Oct 7, 2022

Closes #

πŸ“‘ Description

Added support for async and done code refactoring.

Added async

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@somehybrid
Copy link
Contributor Author

many commits

@interrrp
Copy link

interrrp commented Oct 7, 2022

But you have not updated the documentation as required?! Unacceptable!

@Sas2k
Copy link
Owner

Sas2k commented Oct 8, 2022

Hello, @somehybrid your code on the async support looks great, @1nter-p well there isn't any documentation, the documentation like thing is the Readme's Usage section

@Sas2k
Copy link
Owner

Sas2k commented Oct 8, 2022

If there isn't anything else to add I will pr this in.

1 similar comment
@Sas2k
Copy link
Owner

Sas2k commented Oct 8, 2022

If there isn't anything else to add I will pr this in.

@somehybrid
Copy link
Contributor Author

Updated readme for async usage

@Sas2k Sas2k merged commit ce6b7a3 into Sas2k:main Oct 8, 2022
@Sas2k
Copy link
Owner

Sas2k commented Oct 8, 2022

Ok, now I will PR it

@interrrp
Copy link

interrrp commented Oct 8, 2022

this literally doesn't work, @somehybrid did you even test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants