Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI #454

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

CI #454

wants to merge 2 commits into from

Conversation

ArnoStrouwen
Copy link
Member

Adding safetestsets showed some potentially unwanted interaction between tests.
f(t, y_nv, ydot_nv, user_data) is not really being used, instead it seems like a previously defined 3 argument version is doing all the work. Might want to check if that is the desired behavior.

The downstream CI might not be able to handle packages with _jll in their name, which will require an upstream fix.
There is also a deprecation message I don't quite understand.

Jacobians: Error During Test at C:\Users\arno.julia\packages\SafeTestsets\raUNr\src\SafeTestsets.jl:30
Got exception outside of a test
LoadError: p and/or t provided and are not nothing. But we
potentially detected f(du, u) or f(u). This can be caused by:

  1. f(du, u) or f(u) is defined, in-which case p and/or t should not
    be supplied.
  2. f(args...) is defined, in which case hasmethod can be spurious.

Currently, we perform the check for f(du, u) and f(u) first, but in
future breaking releases, this check will be performed last, which means
that if t is provided f(du, u, p, t)/f(u, p, t) will be given
precedence, similarly if p is provided f(du, u, p)/f(u, p) will be
given precedence.

But it is using NullParameters?
https://github.com/SciML/Sundials.jl/blob/master/test/common_interface/jacobians.jl#L37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant