Add new numerical methods to solve linear system: #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Thomas method (прогонки) 2. Jacobi method (iterative) 3. Seidel method (iterative, improvement version of the Jacobi method)
SPC-code
requested changes
Apr 14, 2024
| * @return vector X - solution of the system 'A*X=B'. | ||
| */ | ||
| @UnstableKMathAPI | ||
| public fun solveSystemByJacobiMethod( |
There was a problem hiding this comment.
Global namespace polution. The method must be made an extension for something. Using Double-only methods is not a KMath way, one should use Field or Ring if one does not need division for that.
| private var cachedMachineEpsilonPrecision: Double? = null | ||
|
|
||
| @UnstableKMathAPI | ||
| public val machineEpsilonPrecision: Double |
There was a problem hiding this comment.
Global namespace polution. And it should be Algebra attribute.
| } | ||
| } | ||
|
|
||
| var X: Point<Double> = initialApproximation |
| return X | ||
| } | ||
|
|
||
| private fun calcNorm(x1: Point<Double>, x2: Point<Double>): Double { |
There was a problem hiding this comment.
The function could be moved inside the only function it is used in
|
|
||
| norm = calcNorm(X, xTmp) | ||
| X = xTmp | ||
| } while (norm > epsilonPrecision) |
| } | ||
| } | ||
|
|
||
| val X: MutableStructure1D<Double> = initialApproximation?.let { |
| return X | ||
| } | ||
|
|
||
| private fun calcNorm(x1: Point<Double>, x2: Point<Double>): Double { |
| * @return vector X - solution of the system 'A*X=B'. | ||
| */ | ||
| @UnstableKMathAPI | ||
| public fun solveSystemByThomasMethod( |
There was a problem hiding this comment.
Global namespace pollution and unnecessary specialization. The same as above.
| ) | ||
|
|
||
| assertEquals(4, result.size) | ||
| val absoluteTolerance = 0.00000000000001 |
There was a problem hiding this comment.
There is a test method for structure equality
| */ | ||
| @Test | ||
| fun exceptionTest1() = | ||
| Double.algebra.linearSpace.run { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and unit tests.